daengdeni/basicdata
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

refactor(basicdata): optimasi autentikasi dan pengelolaan user di controller

Browse Source 
- Memindahkan autentikasi user dari metode `getUser` ke properti `user` di konstruktor controller.
- Mengganti semua pemanggilan metode `getUser` dengan properti `$this->user`.
- Memastikan validasi hak akses user menggunakan properti `$this->user` di seluruh fungsi controller:
  - `BranchController`
  - `CurrencyController`
  - `HolidayCalendarController`.
- Menghapus rute restore yang tidak digunakan pada Branch dan Currency.
- Menggunakan `Route::resource` untuk HolidayCalendarController agar lebih ringkas.
- Menambahkan dependensi `use Illuminate\Support\Facades\Auth` pada HolidayCalendarController demi konsistensi autentikasi.

Perubahan ini bertujuan untuk menyederhanakan pengelolaan user dan meningkatkan konsistensi autentikasi dalam modul.

Signed-off-by: Daeng Deni Mardaeni <ddeni05@gmail.com>
This commit is contained in:
Daeng Deni Mardaeni
2025-05-17 13:48:11 +07:00
parent 4c6a6d8cea
commit 1998d89f84
4 changed files with 50 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
routes/web.php
View File

@@ -19,7 +19,6 @@
Route::middleware(['auth'])->group(function () {
Route::name('basicdata.')->prefix('basic-data')->group(function () {
Route::name('currency.')->prefix('mata-uang')->group(function () {
Route::get('restore/{id}', [CurrencyController::class, 'restore'])->name('restore');
Route::get('datatables', [CurrencyController::class, 'dataForDatatables'])->name('datatables');
Route::get('export', [CurrencyController::class, 'export'])->name('export');
Route::post('delete-multiple', [CurrencyController::class, 'deleteMultiple'])->name('deleteMultiple');
@@ -39,7 +38,6 @@
Route::name('branch.')->prefix('cabang')->group(function () {
Route::get('restore/{id}', [BranchController::class, 'restore'])->name('restore');
Route::get('datatables', [BranchController::class, 'dataForDatatables'])->name('datatables');
Route::get('export', [BranchController::class, 'export'])->name('export');
Route::post('delete-multiple', [BranchController::class, 'deleteMultiple'])->name('deleteMultiple');
@@ -58,15 +56,10 @@
]);
Route::group(['prefix' => 'holidaycalendar', 'as' => 'holidaycalendar.'], function () {
Route::get('/', [HolidayCalendarController::class, 'index'])->name('index');
Route::get('/create', [HolidayCalendarController::class, 'create'])->name('create');
Route::post('/', [HolidayCalendarController::class, 'store'])->name('store');
Route::get('/{id}/edit', [HolidayCalendarController::class, 'edit'])->name('edit');
Route::put('/{id}', [HolidayCalendarController::class, 'update'])->name('update');
Route::delete('/{id}', [HolidayCalendarController::class, 'destroy'])->name('destroy');
Route::get('/datatables', [HolidayCalendarController::class, 'dataForDatatables'])->name('datatables');
Route::get('/export', [HolidayCalendarController::class, 'export'])->name('export');
Route::post('delete-multiple', [HolidayCalendarController::class, 'deleteMultiple'])->name('deleteMultiple');
});
Route::resource('holidaycalendar', HolidayCalendarController::class);
});
});