Merge branch 'staging' into feature/senior-officer

app/Helpers/Lpj.php

@@ -5,6 +5,7 @@
     use Modules\Lpj\Models\HolidayCalendar;
     use Modules\Lpj\Models\PenawaranDetailTender;
     use Modules\Lpj\Models\PenawaranTender;
+    use Modules\Lpj\Models\Penilaian;
 
     function formatTanggalIndonesia($date, $time = false)
     {
@@ -117,6 +118,10 @@
         // nomor di set 0001
         $noUrutAkhirString = sprintf("%04s", 1);
         if($penawaran)
+        {
+            $isNum = substr($maxCode, 2); // memastikan string ke 3 s/d 8 adalan numiric
+            $isNP = substr($maxCode, 0, 2);
+            if((8 == strlen($maxCode)) && ("NP"==$isNP) && (isNumeric($isNum)))
             {
                 $code_penawaran_last = substr ($maxCode, -4);
                 $year_penawaran_last = Carbon::parse($penawaran->created_at)->year;
@@ -127,9 +132,16 @@
                  // jika ternyata tahun tdk sama (kurang dari tahun sekarang), maka nomor di set 0001
             }
 
+        }
+
         return 'NP' . Carbon::now()->format('y') . $noUrutAkhirString;
     }
 
+    function isNumeric($str)
+    {
+        return ctype_digit($str);
+    }
+
     // generate last penawaran.no_spk
     function onLastnumberCodePenawaranSPK($jenis_laporan_code): string
     {
@@ -272,3 +284,10 @@
             },
         )->toArray();
     }
+
+    function countPermohonanForUser($userId)
+    {
+        return Penilaian::whereHas('userPenilai', function ($query) use ($userId) {
+            $query->where('user_id', $userId);
+        })->count();
+    }

app/Http/Controllers/ActivityController.php

@@ -33,42 +33,27 @@ class ActivityController extends Controller
 
     public function progres_activity()
     {
-        // Ambil user yang sedang login
-        $user = auth()->user();
-        $roles = $user->load('roles');
+        // Ambil user yang sedang login dengan roles
+        $user = auth()->user()->load('roles');
 
-        // Inisialisasi regionId dan teamId sebagai null agar bisa dinamis
-        $regionId = null;
-        $teamId = null;
+        // Inisialisasi regionId dan teamId
+        $regionId = $teamId = null;
 
-        if ($roles->roles->pluck('name')->contains('senior-officer')) {
-            $userTeam = TeamsUsers::with('team')
-                ->where('user_id', $user->id)
-                ->first();
+        if ($user->roles->pluck('name')->contains('senior-officer')) {
+            $userTeam = TeamsUsers::with('team')->firstWhere('user_id', $user->id);
             $regionId = $userTeam?->team->regions_id;
             $teamId = $userTeam?->teams_id;
-
         }
 
         $teamsActivity = TeamsUsers::with(['user', 'team', 'team.regions', 'user.roles'])
             ->whereHas('team', function ($q) use ($regionId, $teamId) {
-                if ($regionId) {
-                    $q->where('regions_id', $regionId);
-                }
-                if ($teamId) {
-                    $q->where('id', $teamId); // Hanya tim yang sama
-                }
+                $q->when($regionId, fn($q) => $q->where('regions_id', $regionId))
+                  ->when($teamId, fn($q) => $q->where('id', $teamId));
             })
             ->where('user_id', '!=', $user->id)
-            ->whereHas('user.roles', function ($query) {
-                // Filter hanya peran 'surveyor' atau 'surveyor-penilai'
-                $query->whereIn('name', ['surveyor', 'surveyor-penilai']);
-            })
+            ->whereHas('user.roles', fn($q) => $q->whereIn('name', ['surveyor', 'surveyor-penilai']))
             ->get();
 
-
-
-
         return view('lpj::activity.progres_activity.index', compact('teamsActivity'));
     }
 

resources/views/activity/progres_activity/index.blade.php

@@ -73,14 +73,7 @@
                                     </th>
                                     <th class="min-w-[150px]">
                                         <span class="text-base text-gray-900 font-normal">
-                                            @php
-                                                $totalTasks = $item->team->regions->penilaiTeam
-                                                    ->filter(function ($penilaiTeam) use ($item) {
-                                                        return $penilaiTeam->user_id == $item->user->id;
-                                                    })
-                                                    ->count();
-                                            @endphp
-                                            <p>Total Task: {{ $totalTasks }}</p>
+                                            <p>Total Task: {{ countPermohonanForUser($item->user->id) }}</p>
                                         </span>
                                     </th>
                                     <th>