🔧 refactor(laporan): kontrol akses role, optimasi query, dan perbaikan UI
- Tambah role `pemohon-ao` & `pemohon-eo` untuk upload lampiran di LampiranDokumen.php - Implementasi kontrol akses role di lampiran-dokumen.blade.php & laporan/index.blade.php (logika khusus nilai_liquidasi) - Modifikasi query di LaporanController.php: hapus filter approval_eo_at & optimasi kondisi WHERE - Perbaikan formatting query dengan indentasi lebih rapi & maintainable - Standardisasi urutan class CSS di beberapa Blade (activity/index, penilaian/otorisator/index-sla & index) - Pisahkan logika generateLaporanButton jadi function terpisah di laporan/index.blade.php - Perbaikan tampilan tombol laporan berbasis role + cleanup baris kosong & indentasi - Konsistensi UI/UX: responsive design lebih baik, interface clean & styling konsisten dengan Tailwind - Tingkatkan security & maintainability: granular role access, query lebih efisien, code lebih terstruktur
This commit is contained in:
@@ -75,7 +75,10 @@ class LaporanController extends Controller
|
||||
}
|
||||
|
||||
// Retrieve data from the database
|
||||
$query = Permohonan::query()->whereIn('status',['proses-laporan','done', 'paparan', 'proses-paparan'])->whereNotNull('approval_so_at')->whereNotNull('approval_eo_at')->where(function ($q) {
|
||||
$query = Permohonan::query()->whereIn('status',['proses-laporan','done', 'paparan', 'proses-paparan'])
|
||||
->whereNotNull('approval_so_at')
|
||||
//->whereNotNull('approval_eo_at')
|
||||
->where(function ($q) {
|
||||
$q->whereIn('nilai_plafond_id', [1,4])
|
||||
->whereNotNull('approval_dd_at')
|
||||
->orWhereIn('nilai_plafond_id', [2,3]);
|
||||
|
||||
@@ -27,7 +27,7 @@ class LampiranDokumen extends Base
|
||||
{
|
||||
$user = Auth::user();
|
||||
|
||||
if ($user && $user->hasAnyRole(['penilai', 'administrator', 'Penilai', 'admin','surveyor'])) {
|
||||
if ($user && $user->hasAnyRole(['penilai', 'administrator', 'Penilai', 'admin','surveyor','pemohon-ao','pemohon-eo'])) {
|
||||
$file = $fileData['file'];
|
||||
$fileName = $fileData['nama_file'] ?? time() . '_' . $file->getClientOriginalName();
|
||||
$filePath = $file->storeAs('lampiran_dokumen', $fileName, 'public');
|
||||
|
||||
Reference in New Issue
Block a user