From 409718d96a951278554164671a8ba986f0ddc30f Mon Sep 17 00:00:00 2001
From: Daeng Deni Mardaeni <ddeni05@gmail.com>
Date: Fri, 20 Dec 2024 08:58:54 +0700
Subject: [PATCH] "Perbaiki dan Refactor Komponen Address pada Halaman Dokumen

- Menghapus duplikasi kode terkait pengelolaan alamat (province, city, district, village, postal code, address).
- Penempatan ulang elemen-elemen form untuk meningkatkan keterbacaan dan efisiensi."
---
 .../debitur/components/dokumen.blade.php      | 221 +++++++++---------
 1 file changed, 111 insertions(+), 110 deletions(-)

diff --git a/resources/views/debitur/components/dokumen.blade.php b/resources/views/debitur/components/dokumen.blade.php
index 0cae77e..f4a3e30 100644
--- a/resources/views/debitur/components/dokumen.blade.php
+++ b/resources/views/debitur/components/dokumen.blade.php
@@ -132,6 +132,117 @@
             @enderror
         </div>
     </div>
+
+    <div class="flex items-baseline flex-wrap lg:flex-nowrap gap-2.5">
+        <label class="form-label max-w-56">
+            Address
+        </label>
+        <div class="flex flex-wrap items-baseline w-full">
+            <div class="flex flex-col lg:flex-row gap-2 w-full">
+                <div class="flex flex-wrap items-baseline w-full">
+                    <select id="province_code" name="province_code" class="select w-full @error('province_code') border-danger bg-danger-light @enderror">
+                        <option value="">Select Province</option>
+                        @foreach($provinces as $province)
+                            @if(isset($document))
+                                <option value="{{ $province->code }}" {{ isset($document->province_code) && $document->province_code == $province->code?'selected' : '' }}>
+                                    {{ $province->name }}
+                                </option>
+                            @else
+                                <option value="{{ $province->code }}">
+                                    {{ $province->name }}
+                                </option>
+                            @endif
+                            ;
+                        @endforeach
+                    </select>
+                    @error('province_code')
+                    <em class="alert text-danger text-sm">{{ $message }}</em>
+                    @enderror
+                </div>
+                <div class="flex flex-wrap items-baseline w-full">
+                    <select id="city_code" name="city_code" class="select w-full @error('city_code') border-danger bg-danger-light @enderror">
+                        <option value="">Select City</option>
+                        @if(isset($cities))
+                            @foreach($cities as $city)
+                                @if(isset($document))
+                                    <option value="{{ $city->code }}" {{ isset($document->city_code) && $document->city_code == $city->code?'selected' : '' }}>
+                                        {{ $city->name }}
+                                    </option>
+                                @else
+                                    <option value="{{ $city->code }}">
+                                        {{ $city->name }}
+                                    </option>
+                                @endif
+                            @endforeach
+
+                        @endif
+                    </select>
+                    @error('city_code')
+                    <em class="alert text-danger text-sm">{{ $message }}</em>
+                    @enderror
+                </div>
+            </div>
+            <div class="flex flex-col lg:flex-row gap-2 w-full mt-2 lg:mt-5">
+                <div class="flex flex-wrap items-baseline w-full">
+                    <select id="district_code" name="district_code" class="select w-full @error('district_code') border-danger bg-danger-light @enderror">
+                        <option value="">Select District</option>
+                        @if(isset($districts))
+                            @foreach($districts as $district)
+                                @if(isset($document))
+                                    <option value="{{ $district->code }}" {{ isset($document->district_code) && $document->district_code == $district->code?'selected' : '' }}>
+                                        {{ $district->name }}
+                                    </option>
+                                @else
+                                    <option value="{{ $district->code }}">
+                                        {{ $district->name }}
+                                    </option>
+                                @endif
+                            @endforeach
+
+                        @endif
+                    </select>
+                    @error('district_code')
+                    <em class="alert text-danger text-sm">{{ $message }}</em>
+                    @enderror
+                </div>
+                <div class="flex flex-wrap items-baseline w-full">
+                    <select id="village_code" name="village_code" class="select w-full @error('district_code') border-danger bg-danger-light @enderror">
+                        <option value="">Select Village</option>
+                        @if(isset($villages))
+                            @foreach($villages as $village)
+                                @if(isset($document))
+                                    <option value="{{ $village->code }}" {{ isset($document->village_code) && $document->village_code == $village->code?'selected' : '' }}>
+                                        {{ $village->name }}
+                                    </option>
+                                @else
+                                    <option value="{{ $village->code }}">
+                                        {{ $village->name }}
+                                    </option>
+                                @endif
+                            @endforeach
+
+                        @endif
+                    </select>
+                    @error('district_code')
+                    <em class="alert text-danger text-sm">{{ $message }}</em>
+                    @enderror
+                </div>
+                <div class="flex flex-wrap items-baseline w-full">
+                    <input class="input  @error('postal_code') border-danger bg-danger-light @enderror" type="number" id="postal_code" name="postal_code" value="{{ $document->postal_code ?? '' }}" placeholder="Postal Code">
+                    @error('postal_code')
+                    <em class="alert text-danger text-sm">{{ $message }}</em>
+                    @enderror
+                </div>
+            </div>
+            <div class="flex flex-row w-full mt-2 lg:mt-5">
+                <textarea class="textarea  @error('address') border-danger bg-danger-light @enderror" rows="3" type="number" id="address" name="address">{{ $document->address ?? '' }}</textarea>
+                @error('address')
+                <em class="alert text-danger text-sm">{{ $message }}</em>
+                @enderror
+            </div>
+        </div>
+    </div>
+
     <div id="doctainer" class="grid gap-5">
         @if(isset($document->id))
             @php $n = 0; @endphp
@@ -304,116 +415,6 @@
             @endforeach
         @endif
     </div>
-
-    <div class="flex items-baseline flex-wrap lg:flex-nowrap gap-2.5">
-        <label class="form-label max-w-56">
-            Address
-        </label>
-        <div class="flex flex-wrap items-baseline w-full">
-            <div class="flex flex-col lg:flex-row gap-2 w-full">
-                <div class="flex flex-wrap items-baseline w-full">
-                    <select id="province_code" name="province_code" class="select w-full @error('province_code') border-danger bg-danger-light @enderror">
-                        <option value="">Select Province</option>
-                        @foreach($provinces as $province)
-                            @if(isset($document))
-                                <option value="{{ $province->code }}" {{ isset($document->province_code) && $document->province_code == $province->code?'selected' : '' }}>
-                                    {{ $province->name }}
-                                </option>
-                            @else
-                                <option value="{{ $province->code }}">
-                                    {{ $province->name }}
-                                </option>
-                            @endif
-                            ;
-                        @endforeach
-                    </select>
-                    @error('province_code')
-                    <em class="alert text-danger text-sm">{{ $message }}</em>
-                    @enderror
-                </div>
-                <div class="flex flex-wrap items-baseline w-full">
-                    <select id="city_code" name="city_code" class="select w-full @error('city_code') border-danger bg-danger-light @enderror">
-                        <option value="">Select City</option>
-                        @if(isset($cities))
-                            @foreach($cities as $city)
-                                @if(isset($document))
-                                    <option value="{{ $city->code }}" {{ isset($document->city_code) && $document->city_code == $city->code?'selected' : '' }}>
-                                        {{ $city->name }}
-                                    </option>
-                                @else
-                                    <option value="{{ $city->code }}">
-                                        {{ $city->name }}
-                                    </option>
-                                @endif
-                            @endforeach
-
-                        @endif
-                    </select>
-                    @error('city_code')
-                    <em class="alert text-danger text-sm">{{ $message }}</em>
-                    @enderror
-                </div>
-            </div>
-            <div class="flex flex-col lg:flex-row gap-2 w-full mt-2 lg:mt-5">
-                <div class="flex flex-wrap items-baseline w-full">
-                    <select id="district_code" name="district_code" class="select w-full @error('district_code') border-danger bg-danger-light @enderror">
-                        <option value="">Select District</option>
-                        @if(isset($districts))
-                            @foreach($districts as $district)
-                                @if(isset($document))
-                                    <option value="{{ $district->code }}" {{ isset($document->district_code) && $document->district_code == $district->code?'selected' : '' }}>
-                                        {{ $district->name }}
-                                    </option>
-                                @else
-                                    <option value="{{ $district->code }}">
-                                        {{ $district->name }}
-                                    </option>
-                                @endif
-                            @endforeach
-
-                        @endif
-                    </select>
-                    @error('district_code')
-                    <em class="alert text-danger text-sm">{{ $message }}</em>
-                    @enderror
-                </div>
-                <div class="flex flex-wrap items-baseline w-full">
-                    <select id="village_code" name="village_code" class="select w-full @error('district_code') border-danger bg-danger-light @enderror">
-                        <option value="">Select Village</option>
-                        @if(isset($villages))
-                            @foreach($villages as $village)
-                                @if(isset($document))
-                                    <option value="{{ $village->code }}" {{ isset($document->village_code) && $document->village_code == $village->code?'selected' : '' }}>
-                                        {{ $village->name }}
-                                    </option>
-                                @else
-                                    <option value="{{ $village->code }}">
-                                        {{ $village->name }}
-                                    </option>
-                                @endif
-                            @endforeach
-
-                        @endif
-                    </select>
-                    @error('district_code')
-                    <em class="alert text-danger text-sm">{{ $message }}</em>
-                    @enderror
-                </div>
-                <div class="flex flex-wrap items-baseline w-full">
-                    <input class="input  @error('postal_code') border-danger bg-danger-light @enderror" type="number" id="postal_code" name="postal_code" value="{{ $document->postal_code ?? '' }}" placeholder="Postal Code">
-                    @error('postal_code')
-                    <em class="alert text-danger text-sm">{{ $message }}</em>
-                    @enderror
-                </div>
-            </div>
-            <div class="flex flex-row w-full mt-2 lg:mt-5">
-                <textarea class="textarea  @error('address') border-danger bg-danger-light @enderror" rows="3" type="number" id="address" name="address">{{ $document->address ?? '' }}</textarea>
-                @error('address')
-                <em class="alert text-danger text-sm">{{ $message }}</em>
-                @enderror
-            </div>
-        </div>
-    </div>
     <div class="flex justify-end">
         <button type="submit" class="btn btn-primary">
             Save