daengdeni/lpj
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(bank-data): perbaiki logika penyimpanan data pembanding

Browse Source 
- Menambahkan kategori 'data_pembanding' saat menyimpan data ke BankData.
- Memperbaiki penanganan koordinat yang tidak valid dengan logging.
- Memastikan data yang diambil dari request diolah dengan benar sebelum disimpan.
This commit is contained in:
Daeng Deni Mardaeni
2025-04-08 09:39:11 +07:00
parent 548956d403
commit 4e9c4cea0f
1 changed files with 219 additions and 208 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
app/Http/Controllers/BankDataController.php
View File

@@ -4,12 +4,13 @@ namespace Modules\Lpj\Http\Controllers;
use Illuminate\Http\Request; use Illuminate\Http\Request;
use Illuminate\Routing\Controller; use Illuminate\Routing\Controller;
use Log;
use Modules\Location\Models\Province;
use Modules\Lpj\Http\Requests\BankDataRequest; use Modules\Lpj\Http\Requests\BankDataRequest;
use Modules\Lpj\Models\BankData; use Modules\Lpj\Models\BankData;
use Modules\Lpj\Models\Inspeksi; use Modules\Lpj\Models\Inspeksi;
use Modules\Lpj\Models\JenisJaminan; use Modules\Lpj\Models\JenisJaminan;
use Modules\Lpj\Services\BankDataService; use Modules\Lpj\Services\BankDataService;
use Modules\Location\Models\Province;
class BankDataController extends Controller class BankDataController extends Controller
{ {
@@ -65,6 +66,7 @@ class BankDataController extends Controller
'jenis_aset' => $dataPembanding->jenis_aset, 'jenis_aset' => $dataPembanding->jenis_aset,
'foto_objek' => $dataPembanding->foto_objek, 'foto_objek' => $dataPembanding->foto_objek,
'tanggal' => $dataPembanding->tanggal, 'tanggal' => $dataPembanding->tanggal,
'kategori' => 'data_pembanding',
]; ];
BankData::updateOrCreate( BankData::updateOrCreate(
@@ -77,7 +79,7 @@ class BankDataController extends Controller
} }
} else { } else {
// Invalid coordinates // Invalid coordinates
\Log::warning("Invalid coordinates: Lat: $lat, Lng: $lng");// Do something to handle this situation, such as logging an error or skipping the record Log::warning("Invalid coordinates: Lat: $lat, Lng: $lng");// Do something to handle this situation, such as logging an error or skipping the record
} }
} }
} }
@@ -95,7 +97,9 @@ class BankDataController extends Controller
{ {
$data = $request->validated(); $data = $request->validated();
$bankData = $this->bankDataService->createBankData($data); $bankData = $this->bankDataService->createBankData($data);
return redirect()->route('lpj.bank-data.show', $bankData->id)->with('success', 'Bank data created successfully.'); return redirect()
->route('lpj.bank-data.show', $bankData->id)
->with('success', 'Bank data created successfully.');
} }
public function show($id) public function show($id)
@@ -114,7 +118,9 @@ class BankDataController extends Controller
{ {
$data = $request->validated(); $data = $request->validated();
$bankData = $this->bankDataService->updateBankData($id, $data); $bankData = $this->bankDataService->updateBankData($id, $data);
return redirect()->route('lpj.bank-data.show', $bankData->id)->with('success', 'Bank data updated successfully.'); return redirect()
->route('lpj.bank-data.show', $bankData->id)
->with('success', 'Bank data updated successfully.');
} }
public function destroy($id) public function destroy($id)
@@ -142,6 +148,10 @@ class BankDataController extends Controller
$query->ofProvince($search['province_code']); $query->ofProvince($search['province_code']);
} }
if ($search['kategori']) {
$query->where('kategori',$search['kategori']);
}
if ($search['city_code']) { if ($search['city_code']) {
$query->ofCity($search['city_code']); $query->ofCity($search['city_code']);
} }
@@ -204,6 +214,7 @@ class BankDataController extends Controller
'luas_tanah' => $item->luas_tanah, 'luas_tanah' => $item->luas_tanah,
'luas_bangunan' => $item->luas_bangunan, 'luas_bangunan' => $item->luas_bangunan,
'harga' => $item->harga, 'harga' => $item->harga,
'sumber' => $item->kategori ? ucwords(str_replace('_',' ',$item->kategori)) : '-',
'nilai_pasar' => $item->nilai_pasar, 'nilai_pasar' => $item->nilai_pasar,
'location' => $item->kordinat_lat . ', ' . $item->kordinat_lng, 'location' => $item->kordinat_lat . ', ' . $item->kordinat_lng,
'address' => formatAlamat($item), 'address' => formatAlamat($item),