From 970ecff9dc56d72c36837dae06f564da6194b6c8 Mon Sep 17 00:00:00 2001 From: Daeng Deni Mardaeni Date: Sun, 29 Dec 2024 09:09:39 +0700 Subject: [PATCH 1/3] Perbaiki validasi dan tambahkan pesan default untuk rute lokasi - Menambahkan validasi tambahan untuk memastikan `rute_menuju_lokasi` adalah array sebelum melakukan iterasi. - Menambahkan pesan default "No route information available" jika data rute tidak tersedia. --- resources/views/penilai/components/memo.blade.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/resources/views/penilai/components/memo.blade.php b/resources/views/penilai/components/memo.blade.php index 47a2a78..afb2043 100644 --- a/resources/views/penilai/components/memo.blade.php +++ b/resources/views/penilai/components/memo.blade.php @@ -323,7 +323,7 @@
- @if (isset($formFoto)) + @if (isset($formFoto) && isset($formFoto['rute_menuju_lokasi']) && is_array($formFoto['rute_menuju_lokasi'])) @foreach ($formFoto['rute_menuju_lokasi'] as $item)
@@ -336,6 +336,8 @@
@endforeach + @else +

No route information available.

@endif
From 837f9fc098545bb1c50001526dce2746dd857183 Mon Sep 17 00:00:00 2001 From: Daeng Deni Mardaeni Date: Sun, 29 Dec 2024 09:21:16 +0700 Subject: [PATCH 2/3] Refactor handling data memo dan penyesuaian form lokasi - Memperbaiki struktur data `memo` menjadi objek `lokasi` untuk konsistensi penanganan data. - Menambahkan properti tambahan pada objek `lokasi`, seperti `tanggal_survey` dan `penilai`. - Memperbarui logika query terkait kota, kecamatan, dan kelurahan berdasarkan struktur baru. - Mengubah atribut form dan placeholder untuk mencocokkan perubahan struktur data. --- app/Http/Controllers/PenilaiController.php | 18 +++++++++------- .../views/penilai/components/memo.blade.php | 21 +++++++++++-------- 2 files changed, 22 insertions(+), 17 deletions(-) diff --git a/app/Http/Controllers/PenilaiController.php b/app/Http/Controllers/PenilaiController.php index e35b519..bdcee2b 100644 --- a/app/Http/Controllers/PenilaiController.php +++ b/app/Http/Controllers/PenilaiController.php @@ -158,21 +158,23 @@ class PenilaiController extends Controller $provinces = Province::all(); $basicData = $this->surveyorController->getCommonData(); - $formFoto = $formPeta = $cities = $districts = $villages= null; + $formFoto = $formPeta = $cities = $districts = $villages= $memo = null; if ($inspeksi) { $formFoto = json_decode($inspeksi->foto_form, true); $formPeta = json_decode($inspeksi->data_form, true); - $memo = json_decode($penilai->memo); - if(isset($memo->province_code)){ - $cities = City::where('province_id', $memo->province_code)->get(); + if(isset($penilai->memo)) { + $memo = json_decode($penilai->memo); + } + if(isset($memo->lokasi->province_code)){ + $cities = City::where('province_code', $memo->lokasi->province_code)->get(); } - if(isset($memo->city_code)){ - $districts = District::where('city_id', $memo->city_code)->get(); + if(isset($memo->lokasi->city_code)){ + $districts = District::where('city_code', $memo->lokasi->city_code)->get(); } - if(isset($memo->district_code)) { - $villages = Village::where('district_id', $memo->district_code)->get(); + if(isset($memo->lokasi->district_code)) { + $villages = Village::where('district_code', $memo->lokasi->district_code)->get(); } } diff --git a/resources/views/penilai/components/memo.blade.php b/resources/views/penilai/components/memo.blade.php index afb2043..73d0783 100644 --- a/resources/views/penilai/components/memo.blade.php +++ b/resources/views/penilai/components/memo.blade.php @@ -91,10 +91,10 @@
- +
- +
@@ -104,7 +104,7 @@
@@ -117,7 +117,7 @@ @if(isset($cities)) @foreach ($cities as $item) - + @endforeach @endif @@ -131,7 +131,7 @@ @if(isset($districts)) @foreach ($districts as $item) - + @endforeach @endif @@ -145,7 +145,7 @@ @if(isset($villages)) @foreach ($villages as $item) - + @endforeach @endif @@ -156,7 +156,7 @@
+ placeholder="Masukkan Jl." value="{{ $memo->lokasi->address ?? old('address') }}">
@@ -172,7 +172,7 @@
+ placeholder="Masukkan Penilai" value="{{ $memo->lokasi->penilai ?? old('penilai') }}">
@@ -477,11 +477,14 @@ perihal: formData.get('perihal'), jenis_asset_tidak_sesuai: formData.get('jenis_asset_tidak_sesuai'), lokasi: { + lokasi: formData.get('lokasi') || '', address: formData.get('address') || '', province_code: formData.get('province_code') || '', city_code: formData.get('city_code') || '', district_code: formData.get('district_code') || '', village_code: formData.get('village_code') || '', + tanggal_survey: formData.get('tanggal_survey') || '', + penilai: formData.get('penilai') || '', }, terlampir: (formData.getAll('terlampir[]') || []), hasil_survey: (formData.getAll('hasil_survey[]') || []), From 121b5df9df518abbba4d2620ab64115aec8a5563 Mon Sep 17 00:00:00 2001 From: Daeng Deni Mardaeni Date: Sun, 29 Dec 2024 10:37:42 +0700 Subject: [PATCH 3/3] Update format and display additional city info for KJPP dropdown - Mengubah tanda pemisah dari "||" menjadi "|" pada daftar KJPP. - Menambahkan informasi kota untuk KJPP dengan jenis "Kantor Cabang". - Membersihkan nama kota dengan menghapus prefix seperti "KOTA", "KAB.", atau "KAB". --- resources/views/prosespenawaran/createPenawaran.blade.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/resources/views/prosespenawaran/createPenawaran.blade.php b/resources/views/prosespenawaran/createPenawaran.blade.php index 619e412..85bfcfb 100644 --- a/resources/views/prosespenawaran/createPenawaran.blade.php +++ b/resources/views/prosespenawaran/createPenawaran.blade.php @@ -78,7 +78,10 @@ @if (isset($kjpp)) @endif @endforeach