From b79b65ea6ca18cdec94c6c217cc4fe0d1d989625 Mon Sep 17 00:00:00 2001 From: Daeng Deni Mardaeni Date: Mon, 10 Mar 2025 13:43:10 +0700 Subject: [PATCH] fix(surveyor): perbaiki logika pembaruan laporan eksternal - Memperbarui status permohonan menjadi 'survey-completed' setelah validasi berhasil. - Menambahkan kondisi untuk hanya membuat atau memperbarui laporan eksternal jika jenis penilaian adalah 'External'. - Menggunakan relasi 'jenisPenilaian' untuk mendapatkan informasi yang diperlukan. --- app/Http/Controllers/SurveyorController.php | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/app/Http/Controllers/SurveyorController.php b/app/Http/Controllers/SurveyorController.php index 2b22ff9..f250222 100644 --- a/app/Http/Controllers/SurveyorController.php +++ b/app/Http/Controllers/SurveyorController.php @@ -762,21 +762,23 @@ class SurveyorController extends Controller } // If validation passes, update permohonan status - $permohonan = Permohonan::findOrFail($id); + $permohonan = Permohonan::with('jenisPenilaian')->findOrFail($id); $permohonan->update([ 'status' => 'survey-completed', 'submitted_at' => now() ]); - LaporanExternal::updateOrCreate( - ['permohonan_id' => $permohonan->id], - [ - 'nomor_laporan' => $permohonan->nomor_registrasi, - 'tanggal_laporan' => now(), - 'created_by' => Auth::id(), - ] - ); + if($permohonan->jenisPenilaian->name=="External") { + LaporanExternal::updateOrCreate( + ['permohonan_id' => $permohonan->id], + [ + 'nomor_laporan' => $permohonan->nomor_registrasi, + 'tanggal_laporan' => now(), + 'created_by' => Auth::id(), + ] + ); + } return response()->json([