refactor(BankDataController): improve code structure and enhance data handling for inspections

app/Http/Controllers/BankDataController.php

@@ -1,19 +1,19 @@
 <?php
 
-    namespace Modules\Lpj\Http\Controllers;
+namespace Modules\Lpj\Http\Controllers;
 
-    use Illuminate\Http\Request;
-    use Illuminate\Routing\Controller;
-    use Log;
-    use Modules\Location\Models\Province;
-    use Modules\Lpj\Http\Requests\BankDataRequest;
-    use Modules\Lpj\Models\BankData;
-    use Modules\Lpj\Models\Inspeksi;
-    use Modules\Lpj\Models\JenisJaminan;
-    use Modules\Lpj\Services\BankDataService;
+use Illuminate\Http\Request;
+use Illuminate\Routing\Controller;
+use Illuminate\Support\Facades\Log;
+use Modules\Location\Models\Province;
+use Modules\Lpj\Http\Requests\BankDataRequest;
+use Modules\Lpj\Models\BankData;
+use Modules\Lpj\Models\Inspeksi;
+use Modules\Lpj\Models\JenisJaminan;
+use Modules\Lpj\Services\BankDataService;
 
-    class BankDataController extends Controller
-    {
+class BankDataController extends Controller
+{
     protected $bankDataService;
     protected $user;
 
@@ -88,11 +88,15 @@
                         }
                     } else {
                         // Invalid coordinates
-                            Log::warning("Invalid coordinates: Lat: $_lat, Lng: $_lng");// Do something to handle this situation, such as logging an error or skipping the record
+                        Log::warning("Invalid coordinates: Lat: $_lat, Lng: $_lng"); // Do something to handle this situation, such as logging an error or skipping the record
                     }
                 }
 
+                if (isset($data_pembanding->data_pembanding)) {
                     foreach ($data_pembanding->data_pembanding as $dataPembanding) {
+                        if (!isset($dataPembanding->kordinat_lat) || !isset($dataPembanding->kordinat_lng)) {
+                            continue;
+                        }
                         $lat = $dataPembanding->kordinat_lat;
                         $lng = $dataPembanding->kordinat_lng;
 
@@ -123,7 +127,7 @@
                                     'hak_properti'     => $dataPembanding->hak_properti,
                                     'jenis_aset'       => $dataPembanding->jenis_aset,
                                     'foto_objek'       => $dataPembanding->foto_objek,
-                                    'tanggal'          => $dataPembanding->tanggal,
+                                    'tanggal'          => $dataPembanding->tanggal ?? null,
                                     'kategori'         => 'data_pembanding',
                                 ];
 
@@ -138,7 +142,8 @@
                             }
                         } else {
                             // Invalid coordinates
-                            Log::warning("Invalid coordinates: Lat: $lat, Lng: $lng");// Do something to handle this situation, such as logging an error or skipping the record
+                            Log::warning("Invalid coordinates: Lat: $lat, Lng: $lng"); // Do something to handle this situation, such as logging an error or skipping the record
+                        }
                     }
                 }
             }
@@ -272,7 +277,7 @@
             return [
                 'id'            => $item->id,
                 'jenis_aset'    => $item->jenis_aset,
-                    'tanggal'       => $item->tanggal ? $item->tanggal->format('d-m-Y') : '-',
+                'tanggal'       => isset($item->tanggal) && $item->tanggal ? $item->tanggal->format('d-m-Y') : '-',
                 'tahun'         => $item->tahun,
                 'luas_tanah'    => $item->luas_tanah,
                 'luas_bangunan' => $item->luas_bangunan,
@@ -308,4 +313,4 @@
             'data'            => $formattedData,
         ]);
     }
-    }
+}