From f5119e188a74e665e1437807683939b40e1becda Mon Sep 17 00:00:00 2001 From: Daeng Deni Mardaeni Date: Fri, 20 Dec 2024 11:24:26 +0700 Subject: [PATCH] Perbaiki logika validasi jenis legalitas jaminan - Tambahkan pengecekan null untuk menghindari error ketika `_jenisJaminan` kosong. - Perbaiki pengolahan data pada `legalitasJaminan` dan `currentLegalitasJaminan` agar lebih aman. - Pastikan variabel `legalitas` hanya diisi jika `_jenisJaminan` valid. --- .../Controllers/DokumenJaminanController.php | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/app/Http/Controllers/DokumenJaminanController.php b/app/Http/Controllers/DokumenJaminanController.php index 51364d9..2e14fdf 100644 --- a/app/Http/Controllers/DokumenJaminanController.php +++ b/app/Http/Controllers/DokumenJaminanController.php @@ -327,18 +327,21 @@ $jenisLegalitasJaminan = JenisLegalitasJaminan::all(); $_jenisJaminan = JenisJaminan::find($document->jenis_jaminan_id); - $legalitasJaminan = json_decode($_jenisJaminan->jenis_legalitas_jaminan_id, true); + $legalitas=''; + if($_jenisJaminan) { + $legalitasJaminan = json_decode($_jenisJaminan->jenis_legalitas_jaminan_id, true); - $currentLegalitasJaminan = JenisLegalitasJaminan::whereIn( - 'id', - $document->detail->pluck('jenis_legalitas_jaminan_id')->toArray(), - )->get(); + $currentLegalitasJaminan = JenisLegalitasJaminan::whereIn( + 'id', + $document->detail->pluck('jenis_legalitas_jaminan_id')->toArray(), + )->get(); - // Remove values from $legalitasJaminan that are in $currentLegalitasJaminan - $legalitasJaminan = array_diff($legalitasJaminan, $currentLegalitasJaminan->pluck('code')->toArray()); + // Remove values from $legalitasJaminan that are in $currentLegalitasJaminan + $legalitasJaminan = array_diff($legalitasJaminan, $currentLegalitasJaminan->pluck('code')->toArray()); - $legalitas = JenisLegalitasJaminan::whereIn('code', $legalitasJaminan)->get(); + $legalitas = JenisLegalitasJaminan::whereIn('code', $legalitasJaminan)->get(); + } $pemilikJaminan = PemilikJaminan::where('debiture_id', $document->debiture_id)->get(); $hubunganPemilik = HubunganPemilikJaminan::all();