From 3414fd9414cd10573980243beb939ef6f3595938 Mon Sep 17 00:00:00 2001 From: Daeng Deni Mardaeni Date: Fri, 23 May 2025 21:42:46 +0700 Subject: [PATCH] fix(webstatement): optimize balance assignment in ProcessAccountDataJob - Mengubah logika assignment nilai balance untuk memanfaatkan operator null coalescing (??). - Menghapus pengecekan eksplisit untuk `isset` pada `open_actual_bal` dan `open_cleared_bal`. - Menambahkan default value `0` jika data balance tidak tersedia. Signed-off-by: Daeng Deni Mardaeni --- app/Jobs/ProcessAccountDataJob.php | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/app/Jobs/ProcessAccountDataJob.php b/app/Jobs/ProcessAccountDataJob.php index 439cfcf..82934c1 100644 --- a/app/Jobs/ProcessAccountDataJob.php +++ b/app/Jobs/ProcessAccountDataJob.php @@ -102,13 +102,8 @@ ]); // Set the balances - if (isset($data['open_actual_bal'])) { - $accountBalance->actual_balance = $data['open_actual_bal']; - } - - if (isset($data['open_cleared_bal'])) { - $accountBalance->cleared_balance = $data['open_cleared_bal']; - } + $accountBalance->actual_balance = $data['open_actual_bal'] ?? 0; + $accountBalance->cleared_balance = $data['open_cleared_bal'] ?? 0; $accountBalance->save(); Log::info("Saved balance for account {$data['account_number']} for period $period");