daengdeni/webstatement
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(webstatement): ubah parameter periode dari array menjadi string

Browse Source 
- Mengubah parameter pada metode `ProcessCategoryData` di `MigrasiController` dari array menjadi string untuk keseragaman dengan metode lainnya.
- Memperbarui konstruksi parameter pada instansi `ProcessCategoryDataJob` untuk menerima tipe data string sebagai pengganti array.
- Menghilangkan iterasi array `periods` pada `ProcessCategoryDataJob` dan menerapkan logika langsung pada single `period`.
- Menyesuaikan validasi periode untuk mengabaikan folder `_parameter` dalam proses.
- Memperlihatkan log lebih spesifik jika file tidak ditemukan, atau format kolom tidak sesuai ekspektasi.

Signed-off-by: Daeng Deni Mardaeni <ddeni05@gmail.com>
This commit is contained in:
Daeng Deni Mardaeni
2025-05-24 19:19:33 +07:00
parent b894a2c9c4
commit bf7206f927
2 changed files with 73 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Http/Controllers/MigrasiController.php
View File

@@ -252,7 +252,7 @@ class MigrasiController extends Controller
return response()->json(["message" => "Period {$period} folder not found in SFTP storage"], 404); return response()->json(["message" => "Period {$period} folder not found in SFTP storage"], 404);
} }
$this->ProcessCategoryData([$period]); $this->ProcessCategoryData($period);
$this->ProcessCompanyData([$period]); $this->ProcessCompanyData([$period]);
$this->processCustomerData([$period]); $this->processCustomerData([$period]);

22
app/Jobs/ProcessCategoryDataJob.php
View File

@@ -16,14 +16,14 @@
{ {
use Dispatchable, InteractsWithQueue, Queueable, SerializesModels; use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
protected $periods; protected $period;
/** /**
* Create a new job instance. * Create a new job instance.
*/ */
public function __construct(array $periods = []) public function __construct(string $period = '')
{ {
$this->periods = $periods; $this->period = $period;
} }
/** /**
@@ -38,27 +38,26 @@
$processedCount = 0; $processedCount = 0;
$errorCount = 0; $errorCount = 0;
if (empty($this->periods)) { if (empty($this->period)) {
Log::warning('No periods provided for category data processing'); Log::warning('No period provided for category data processing');
return; return;
} }
foreach ($this->periods as $period) {
// Skip the _parameter folder // Skip the _parameter folder
if ($period === '_parameter') { if ($this->period === '_parameter') {
Log::info("Skipping _parameter folder"); Log::info("Skipping _parameter folder");
continue; return;
} }
// Construct the filename based on the period folder name // Construct the filename based on the period folder name
$filename = "$period.ST.CATEGORY.csv"; $filename = "{$this->period}.ST.CATEGORY.csv";
$filePath = "$period/$filename"; $filePath = "{$this->period}/$filename";
Log::info("Processing category file: $filePath"); Log::info("Processing category file: $filePath");
if (!$disk->exists($filePath)) { if (!$disk->exists($filePath)) {
Log::warning("File not found: $filePath"); Log::warning("File not found: $filePath");
continue; return;
} }
// Create a temporary local copy of the file // Create a temporary local copy of the file
@@ -126,7 +125,6 @@
} else { } else {
Log::error("Unable to open file: $filePath"); Log::error("Unable to open file: $filePath");
} }
}
Log::info("Category data processing completed. Total processed: $processedCount, Total errors: $errorCount"); Log::info("Category data processing completed. Total processed: $processedCount, Total errors: $errorCount");