daengdeni/webstatement
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(webstatement): ubah parameter periode dari array menjadi string

Browse Source 
- Mengubah parameter pada metode `ProcessCategoryData` di `MigrasiController` dari array menjadi string untuk keseragaman dengan metode lainnya.
- Memperbarui konstruksi parameter pada instansi `ProcessCategoryDataJob` untuk menerima tipe data string sebagai pengganti array.
- Menghilangkan iterasi array `periods` pada `ProcessCategoryDataJob` dan menerapkan logika langsung pada single `period`.
- Menyesuaikan validasi periode untuk mengabaikan folder `_parameter` dalam proses.
- Memperlihatkan log lebih spesifik jika file tidak ditemukan, atau format kolom tidak sesuai ekspektasi.

Signed-off-by: Daeng Deni Mardaeni <ddeni05@gmail.com>
This commit is contained in:
Daeng Deni Mardaeni
2025-05-24 19:19:33 +07:00
parent b894a2c9c4
commit bf7206f927
2 changed files with 73 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Http/Controllers/MigrasiController.php
View File

@@ -252,7 +252,7 @@ class MigrasiController extends Controller
return response()->json(["message" => "Period {$period} folder not found in SFTP storage"], 404); return response()->json(["message" => "Period {$period} folder not found in SFTP storage"], 404);
} }
$this->ProcessCategoryData([$period]); $this->ProcessCategoryData($period);
$this->ProcessCompanyData([$period]); $this->ProcessCompanyData([$period]);
$this->processCustomerData([$period]); $this->processCustomerData([$period]);

146
app/Jobs/ProcessCategoryDataJob.php
View File

@@ -16,14 +16,14 @@
{ {
use Dispatchable, InteractsWithQueue, Queueable, SerializesModels; use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
protected $periods; protected $period;
/** /**
* Create a new job instance. * Create a new job instance.
*/ */
public function __construct(array $periods = []) public function __construct(string $period = '')
{ {
$this->periods = $periods; $this->period = $period;
} }
/** /**
@@ -38,94 +38,92 @@
$processedCount = 0; $processedCount = 0;
$errorCount = 0; $errorCount = 0;
if (empty($this->periods)) { if (empty($this->period)) {
Log::warning('No periods provided for category data processing'); Log::warning('No period provided for category data processing');
return; return;
} }
foreach ($this->periods as $period) { // Skip the _parameter folder
// Skip the _parameter folder if ($this->period === '_parameter') {
if ($period === '_parameter') { Log::info("Skipping _parameter folder");
Log::info("Skipping _parameter folder"); return;
continue; }
}
// Construct the filename based on the period folder name // Construct the filename based on the period folder name
$filename = "$period.ST.CATEGORY.csv"; $filename = "{$this->period}.ST.CATEGORY.csv";
$filePath = "$period/$filename"; $filePath = "{$this->period}/$filename";
Log::info("Processing category file: $filePath"); Log::info("Processing category file: $filePath");
if (!$disk->exists($filePath)) { if (!$disk->exists($filePath)) {
Log::warning("File not found: $filePath"); Log::warning("File not found: $filePath");
continue; return;
} }
// Create a temporary local copy of the file // Create a temporary local copy of the file
$tempFilePath = storage_path("app/temp_$filename"); $tempFilePath = storage_path("app/temp_$filename");
file_put_contents($tempFilePath, $disk->get($filePath)); file_put_contents($tempFilePath, $disk->get($filePath));
$handle = fopen($tempFilePath, "r"); $handle = fopen($tempFilePath, "r");
if ($handle !== false) { if ($handle !== false) {
// Get the headers from the first row // Get the headers from the first row
$headerRow = fgetcsv($handle, 0, "~"); $headerRow = fgetcsv($handle, 0, "~");
// Map the headers to our model fields // Map the headers to our model fields
$headerMap = [ $headerMap = [
'id' => 'id_category', 'id' => 'id_category',
'date_time' => 'date_time', 'date_time' => 'date_time',
'description' => 'description', 'description' => 'description',
'short_name' => 'short_name', 'short_name' => 'short_name',
'system_ind' => 'system_ind', 'system_ind' => 'system_ind',
'record_status' => 'record_status', 'record_status' => 'record_status',
'co_code' => 'co_code', 'co_code' => 'co_code',
'curr_no' => 'curr_no', 'curr_no' => 'curr_no',
'l_db_cr_ind' => 'l_db_cr_ind', 'l_db_cr_ind' => 'l_db_cr_ind',
'category_code' => 'category_code' 'category_code' => 'category_code'
]; ];
$rowCount = 0; $rowCount = 0;
while (($row = fgetcsv($handle, 0, "~")) !== false) { while (($row = fgetcsv($handle, 0, "~")) !== false) {
$rowCount++; $rowCount++;
if (count($headerRow) === count($row)) { if (count($headerRow) === count($row)) {
// Combine the header row with the data row // Combine the header row with the data row
$rawData = array_combine($headerRow, $row); $rawData = array_combine($headerRow, $row);
// Map the raw data to our model fields // Map the raw data to our model fields
$data = []; $data = [];
foreach ($headerMap as $csvField => $modelField) { foreach ($headerMap as $csvField => $modelField) {
$data[$modelField] = $rawData[$csvField] ?? null; $data[$modelField] = $rawData[$csvField] ?? null;
}
try {
// Skip header row if it was included in the data
if ($data['id_category'] !== 'id') {
// Use firstOrNew instead of updateOrCreate
$category = Category::firstOrNew(['id_category' => $data['id_category']]);
$category->fill($data);
$category->save();
$processedCount++;
}
} catch (Exception $e) {
$errorCount++;
Log::error("Error processing Category at row $rowCount in $filePath: " . $e->getMessage());
}
} else {
Log::warning("Row $rowCount in $filePath has incorrect column count. Expected: " . count($headerRow) . ", Got: " . count($row));
} }
try {
// Skip header row if it was included in the data
if ($data['id_category'] !== 'id') {
// Use firstOrNew instead of updateOrCreate
$category = Category::firstOrNew(['id_category' => $data['id_category']]);
$category->fill($data);
$category->save();
$processedCount++;
}
} catch (Exception $e) {
$errorCount++;
Log::error("Error processing Category at row $rowCount in $filePath: " . $e->getMessage());
}
} else {
Log::warning("Row $rowCount in $filePath has incorrect column count. Expected: " . count($headerRow) . ", Got: " . count($row));
} }
fclose($handle);
Log::info("Completed processing $filePath. Processed $processedCount records with $errorCount errors.");
// Clean up the temporary file
unlink($tempFilePath);
} else {
Log::error("Unable to open file: $filePath");
} }
fclose($handle);
Log::info("Completed processing $filePath. Processed $processedCount records with $errorCount errors.");
// Clean up the temporary file
unlink($tempFilePath);
} else {
Log::error("Unable to open file: $filePath");
} }
Log::info("Category data processing completed. Total processed: $processedCount, Total errors: $errorCount"); Log::info("Category data processing completed. Total processed: $processedCount, Total errors: $errorCount");