refactor(webstatement): remove unused date formatting logic in ProcessDataCaptureDataJob
Menghapus logika format tanggal yang tidak dipakai untuk menyederhanakan kode dan meningkatkan keterbacaan. - Menghapus konstanta `DATE_FIELDS` yang tidak lagi digunakan. - Menghapus fungsi `formatDates` beserta implementasinya yang berisi logika untuk format tanggal dan waktu. - Menghilangkan pemanggilan fungsi `formatDates` pada loop proses data CSV. - Optimasi kode untuk mengurangi kompleksitas dan potensi error terkait parsing tanggal/tanggal dan waktu. - Memastikan data diproses tanpa perlu manipulasi format tanggal yang redundant.
This commit is contained in:
@@ -62,8 +62,6 @@
|
|||||||
'co_code',
|
'co_code',
|
||||||
'date_time'
|
'date_time'
|
||||||
];
|
];
|
||||||
private const DATE_FIELDS = ['value_date', 'exposure_date', 'accounting_date'];
|
|
||||||
|
|
||||||
private string $period = '';
|
private string $period = '';
|
||||||
private int $processedCount = 0;
|
private int $processedCount = 0;
|
||||||
private int $errorCount = 0;
|
private int $errorCount = 0;
|
||||||
@@ -194,36 +192,9 @@
|
|||||||
}
|
}
|
||||||
|
|
||||||
$data = array_combine(self::CSV_HEADERS, $row);
|
$data = array_combine(self::CSV_HEADERS, $row);
|
||||||
$this->formatDates($data);
|
|
||||||
$this->addToBatch($data, $rowCount, $filePath);
|
$this->addToBatch($data, $rowCount, $filePath);
|
||||||
}
|
}
|
||||||
|
|
||||||
private function formatDates(array &$data)
|
|
||||||
: void
|
|
||||||
{
|
|
||||||
// Format dates if they exist
|
|
||||||
foreach (self::DATE_FIELDS as $dateField) {
|
|
||||||
if (!empty($data[$dateField])) {
|
|
||||||
try {
|
|
||||||
$data[$dateField] = date('Y-m-d', strtotime($data[$dateField]));
|
|
||||||
} catch (Exception $e) {
|
|
||||||
// If date parsing fails, keep the original value
|
|
||||||
Log::warning("Failed to parse date for $dateField: {$data[$dateField]}");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
// Format datetime if it exists
|
|
||||||
if (!empty($data['date_time'])) {
|
|
||||||
try {
|
|
||||||
$data['date_time'] = date('Y-m-d H:i:s', strtotime($data['date_time']));
|
|
||||||
} catch (Exception $e) {
|
|
||||||
// If datetime parsing fails, keep the original value
|
|
||||||
Log::warning("Failed to parse datetime for date_time: {$data['date_time']}");
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Add record to batch instead of saving immediately
|
* Add record to batch instead of saving immediately
|
||||||
*/
|
*/
|
||||||
|
|||||||
Reference in New Issue
Block a user