refactor(webstatement): optimalkan sinkronisasi dan pembaruan data kartu ATM

- Menghapus dependensi yang tidak digunakan untuk memperingkas kode.
- Memisahkan logika pembaruan branch dan currency menjadi job terpisah `UpdateAtmCardBranchCurrencyJob`.
- Menambahkan penjadwalan job untuk pembaruan branch dan currency setelah sinkronisasi kartu selesai.
- Mengubah query database untuk sinkronisasi kartu menjadi lebih sederhana.
- Menambahkan binding `UpdateAtmCardBranchCurrencyJob` di service provider.

Refactor ini meningkatkan readability dan modularitas kode dengan memisahkan tanggung jawab tiap proses.

Signed-off-by: Daeng Deni Mardaeni <ddeni05@gmail.com>

app/Jobs/BiayaKartu.php

@@ -9,7 +9,6 @@
 use Illuminate\Queue\InteractsWithQueue;
 use Illuminate\Queue\SerializesModels;
 use Illuminate\Support\Facades\DB;
-    use Illuminate\Support\Facades\Http;
 use Illuminate\Support\Facades\Log;
 use Modules\Webstatement\Models\Atmcard;
 
@@ -18,22 +17,22 @@
     use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
 
     /**
-         * API dan database constants
+     * Database constants
      */
-        private const API_BASE_PATH      = '/restgateway/services/IGATEToCoreBankingServices';
+    private const DB_TABLE           = 'IST77.VW_CMS_VCARD';
-        private const API_INQUIRY_PATH   = '/InquiryBalanceService';
-        private const DB_TABLE           = 'IST77.CMS_VCARD';
     private const BATCH_SIZE         = 100;
     private const MAX_EXECUTION_TIME = 86400; // 24 jam dalam detik
 
     /**
      * Execute the job.
      */
-        public function handle()
+    public function handle(): void
-        : void
     {
         set_time_limit(self::MAX_EXECUTION_TIME);
         $this->syncAtmCards();
+
+        // Setelah sync selesai, jadwalkan job untuk memperbarui branch dan currency
+        $this->scheduleUpdateBranchCurrencyJobs();
     }
 
     /**
@@ -41,8 +40,7 @@
      *
      * @return void
      */
-        private function syncAtmCards()
+    private function syncAtmCards(): void
-        : void
     {
         try {
             $offset         = 0;
@@ -76,8 +74,6 @@
     {
         return DB::connection('oracle')
                  ->table(self::DB_TABLE)
-                     ->select('CRDNO','ACCFLAG','CRACC1','CRACC2','CRACC3','CRACC4','CRACC5','CRSTS','CRACCNAM1','CRACCNAM2','CRACCNAM3','CRACCNAM4','CRACCNAM5','CTTYPE','CTDESC','CRDATE','LASTUPDATE')
-                     ->join('IST77.CMS_VCARDTYP','IST77.CMS_VCARD.CRTYPE','=','IST77.CMS_VCARDTYP.CTTYPE')
                  ->where('crsts', 1)
                  ->whereNotNull('ACCFLAG')
                  ->where('ACCFLAG', '>', 0)
@@ -93,23 +89,13 @@
      *
      * @return void
      */
-        private function processCardBatch($cards)
+    private function processCardBatch($cards): void
-        : void
     {
         foreach ($cards as $card) {
             try {
                 // Perbarui data kartu dasar
                 $cardData = $this->getCardBaseData($card);
-
                 Atmcard::updateOrCreate(['crdno' => $card->crdno], $cardData);
-                    $existingCard = $this->getExistingCard($card->crdno);
-                    // Periksa jika perlu memperbarui branch dan currency
-                    if ($this->needBranchAndCurrencyUpdate($existingCard)) {
-                        $accountInfo = $this->getAccountInfo($card->accflag);
-                        if($accountInfo['responseCode'] === '00') {
-                            $this->updateBranchAndCurrency($card->crdno, $accountInfo);
-                        }
-                    }
             } catch (Exception $e) {
                 Log::warning("Gagal memproses kartu {$card->crdno}: " . $e->getMessage());
             }
@@ -117,16 +103,41 @@
     }
 
     /**
-         * Get existing card from database if exists
+     * Schedule update branch and currency jobs for cards that need update
      *
-         * @param string $cardNumber
+     * @return void
-         *
-         * @return Atmcard|null
      */
-        private function getExistingCard(string $cardNumber)
+    private function scheduleUpdateBranchCurrencyJobs(): void
-        : ?Atmcard
     {
-            return Atmcard::where('crdno', $cardNumber)->first();
+        try {
+            // Ambil semua kartu yang perlu diperbarui branch dan currency
+            $cards = Atmcard::where('crsts', 1)
+                           ->whereNotNull('accflag')
+                           ->where('accflag', '!=', '')
+                           ->where(function($query) {
+                               $query->whereNull('branch')
+                                     ->orWhere('branch', '')
+                                     ->orWhereNull('currency')
+                                     ->orWhere('currency', '');
+                           })
+                           ->get();
+
+            $totalCards = $cards->count();
+            Log::info("Menjadwalkan {$totalCards} job pembaruan branch dan currency");
+
+            foreach ($cards as $card) {
+                // Jadwalkan job dengan delay untuk menghindari terlalu banyak request bersamaan
+                UpdateAtmCardBranchCurrencyJob::dispatch($card)
+                    ->delay(now()->addSeconds(rand(1, 300))); // Random delay antara 1-300 detik
+            }
+
+            Log::info('Semua job pembaruan branch dan currency telah dijadwalkan');
+        } catch (Exception $e) {
+            Log::error('Gagal menjadwalkan job pembaruan branch dan currency: ' . $e->getMessage(), [
+                'file' => $e->getFile(),
+                'line' => $e->getLine()
+            ]);
+        }
     }
 
     /**
@@ -136,8 +147,7 @@
      *
      * @return array
      */
-        private function getCardBaseData(object $card)
+    private function getCardBaseData(object $card): array
-        : array
     {
         return [
             'accflag'     => $card->accflag,
@@ -158,60 +168,4 @@
             'last_update' => $card->lastupdate,
         ];
     }
-
-        /**
-         * Check if branch and currency update is needed
-         *
-         * @param Atmcard|null $card
-         *
-         * @return bool
-         */
-        private function needBranchAndCurrencyUpdate(?Atmcard $card)
-        : bool
-        {
-            // Jika kartu belum ada atau branch/currency belum terisi
-            return $card === null || empty($card->branch) || empty($card->currency);
-        }
-
-        /**
-         * Get account information from the API
-         *
-         * @param string $accountNumber
-         *
-         * @return array
-         */
-        private function getAccountInfo(string $accountNumber)
-        : array
-        {
-            $url  = env('FIORANO_URL') . self::API_BASE_PATH;
-            $path = self::API_INQUIRY_PATH;
-            $data = [
-                'accountNo' => $accountNumber
-            ];
-
-            $response = Http::post($url . $path, $data);
-
-            return $response->json();
-        }
-
-        /**
-         * Update branch and currency information for a card
-         *
-         * @param string $cardNumber
-         * @param array  $accountInfo
-         *
-         * @return void
-         */
-        private function updateBranchAndCurrency(string $cardNumber, array $accountInfo)
-        : void
-        {
-            $cardData = [
-                'branch'   => !empty($accountInfo['acctCompany']) ? $accountInfo['acctCompany'] : null,
-                'currency' => !empty($accountInfo['acctCurrency']) ? $accountInfo['acctCurrency'] : null,
-            ];
-
-            Atmcard::where('crdno', $cardNumber)->update($cardData);
-
-            Log::info("Berhasil memperbarui branch dan currency untuk kartu {$cardNumber}");
-        }
 }

app/Jobs/UpdateAtmCardBranchCurrencyJob.php

@@ -0,0 +1,117 @@
+<?php
+
+namespace Modules\Webstatement\Jobs;
+
+use Exception;
+use Illuminate\Bus\Queueable;
+use Illuminate\Contracts\Queue\ShouldQueue;
+use Illuminate\Foundation\Bus\Dispatchable;
+use Illuminate\Queue\InteractsWithQueue;
+use Illuminate\Queue\SerializesModels;
+use Illuminate\Support\Facades\Http;
+use Illuminate\Support\Facades\Log;
+use Modules\Webstatement\Models\Atmcard;
+
+class UpdateAtmCardBranchCurrencyJob implements ShouldQueue
+{
+    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
+
+    /**
+     * API constants
+     */
+    private const API_BASE_PATH    = '/restgateway/services/IGATEToCoreBankingServices';
+    private const API_INQUIRY_PATH = '/InquiryBalanceService';
+
+    /**
+     * The ATM card to update.
+     *
+     * @var Atmcard
+     */
+    protected $card;
+
+    /**
+     * Create a new job instance.
+     *
+     * @param Atmcard $card
+     * @return void
+     */
+    public function __construct(Atmcard $card)
+    {
+        $this->card = $card;
+    }
+
+    /**
+     * Execute the job.
+     *
+     * @return void
+     */
+    public function handle(): void
+    {
+        try {
+            if ($this->needBranchAndCurrencyUpdate()) {
+                $accountInfo = $this->getAccountInfo($this->card->accflag);
+                if ($accountInfo && isset($accountInfo['responseCode']) && $accountInfo['responseCode'] === '00') {
+                    $this->updateBranchAndCurrency($accountInfo);
+                    Log::info("Berhasil memperbarui branch dan currency untuk kartu {$this->card->crdno}");
+                } else {
+                    Log::warning("Gagal mendapatkan informasi akun untuk kartu {$this->card->crdno}. Response: " .
+                                 json_encode($accountInfo ?? ['error' => 'No response']));
+                }
+            }
+        } catch (Exception $e) {
+            Log::error("Error saat memperbarui branch dan currency untuk kartu {$this->card->crdno}: " . $e->getMessage(), [
+                'file' => $e->getFile(),
+                'line' => $e->getLine()
+            ]);
+        }
+    }
+
+    /**
+     * Check if branch and currency update is needed
+     *
+     * @return bool
+     */
+    private function needBranchAndCurrencyUpdate(): bool
+    {
+        return empty($this->card->branch) || empty($this->card->currency);
+    }
+
+    /**
+     * Get account information from the API
+     *
+     * @param string $accountNumber
+     * @return array|null
+     */
+    private function getAccountInfo(string $accountNumber): ?array
+    {
+        try {
+            $url  = env('FIORANO_URL') . self::API_BASE_PATH;
+            $path = self::API_INQUIRY_PATH;
+            $data = [
+                'accountNo' => $accountNumber
+            ];
+
+            $response = Http::post($url . $path, $data);
+            return $response->json();
+        } catch (Exception $e) {
+            Log::error("Gagal mendapatkan informasi akun: " . $e->getMessage());
+            return null;
+        }
+    }
+
+    /**
+     * Update branch and currency information for the card
+     *
+     * @param array $accountInfo
+     * @return void
+     */
+    private function updateBranchAndCurrency(array $accountInfo): void
+    {
+        $cardData = [
+            'branch'   => !empty($accountInfo['acctCompany']) ? $accountInfo['acctCompany'] : null,
+            'currency' => !empty($accountInfo['acctCurrency']) ? $accountInfo['acctCurrency'] : null,
+        ];
+
+        $this->card->update($cardData);
+    }
+}

app/Providers/WebstatementServiceProvider.php

@@ -7,6 +7,7 @@ use Illuminate\Support\Facades\Blade;
 use Illuminate\Support\ServiceProvider;
 use Modules\Webstatement\Console\GenerateBiayakartuCommand;
 use Modules\Webstatement\Console\GenerateBiayaKartuCsvCommand;
+use Modules\Webstatement\Jobs\UpdateAtmCardBranchCurrencyJob;
 use Nwidart\Modules\Traits\PathNamespace;
 
 class WebstatementServiceProvider extends ServiceProvider
@@ -41,6 +42,7 @@ class WebstatementServiceProvider extends ServiceProvider
     {
         $this->app->register(EventServiceProvider::class);
         $this->app->register(RouteServiceProvider::class);
+        $this->app->bind(UpdateAtmCardBranchCurrencyJob::class);
     }
 
     /**
@@ -51,7 +53,6 @@ class WebstatementServiceProvider extends ServiceProvider
         $this->commands([
             GenerateBiayakartuCommand::class,
             GenerateBiayaKartuCsvCommand::class
-
         ]);
     }