From 44f95936441cf47fc0f37f9f1ab82c1dc95bdacd Mon Sep 17 00:00:00 2001
From: Daeng Deni Mardaeni <ddeni05@gmail.com>
Date: Wed, 7 Jun 2023 10:26:03 +0700
Subject: [PATCH] fixing sonarcube

---
 Database/Seeders/AuthDatabaseSeeder.php | 32 ++++++++++---------------
 Entities/User.php                       |  1 -
 Http/Controllers/UserController.php     | 12 ++++------
 Providers/AuthServiceProvider.php       |  3 ++-
 Providers/RouteServiceProvider.php      | 12 ----------
 5 files changed, 19 insertions(+), 41 deletions(-)

diff --git a/Database/Seeders/AuthDatabaseSeeder.php b/Database/Seeders/AuthDatabaseSeeder.php
index c7a1fd0..26b028f 100644
--- a/Database/Seeders/AuthDatabaseSeeder.php
+++ b/Database/Seeders/AuthDatabaseSeeder.php
@@ -1,26 +1,18 @@
 <?php
 
-namespace Modules\Auth\Database\Seeders;
+    namespace Modules\Auth\Database\Seeders;
 
-use Illuminate\Database\Seeder;
-use Illuminate\Database\Eloquent\Model;
+    use Illuminate\Database\Seeder;
+    use Illuminate\Database\Eloquent\Model;
 
-class AuthDatabaseSeeder extends Seeder
-{
-    /**
-     * Run the database seeds.
-     *
-     * @return void
-     */
-    public function run() : void
+    class AuthDatabaseSeeder extends Seeder
     {
-        // \App\Models\User::factory(10)->create();
-
-        // \App\Models\User::factory()->create([
-        //     'name' => 'Test User',
-        //     'email' => 'test@example.com',
-        // ]);
-
-        // $this->call("OthersTableSeeder");
+        /**
+         * Run the database seeds.
+         *
+         * @return void
+         */
+        public function run(): void
+        {
+        }
     }
-}
diff --git a/Entities/User.php b/Entities/User.php
index 23ff675..b8387f5 100644
--- a/Entities/User.php
+++ b/Entities/User.php
@@ -2,7 +2,6 @@
 
 namespace Modules\Auth\Entities;
 
-// use Illuminate\Contracts\Auth\MustVerifyEmail;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Foundation\Auth\User as Authenticatable;
 use Illuminate\Notifications\Notifiable;
diff --git a/Http/Controllers/UserController.php b/Http/Controllers/UserController.php
index 9f24c6d..2460ee2 100644
--- a/Http/Controllers/UserController.php
+++ b/Http/Controllers/UserController.php
@@ -16,8 +16,7 @@
          *
          * @return Renderable
          */
-        public function index()
-        : JsonResponse
+        public function index(): JsonResponse
         {
             $users = User::all();
             return $this->sendResponse($users, 'Users retrieved successfully.');
@@ -30,8 +29,7 @@
          *
          * @return Renderable
          */
-        public function store(Request $request)
-        : JsonResponse
+        public function store(Request $request): JsonResponse
         {
             $validator = Validator::make($request->all(), [
                 'name'                  => 'required',
@@ -59,11 +57,11 @@
          *
          * @return Renderable
          */
-        public function show($id) : JsonResponse
+        public function show($id): JsonResponse
         {
             $user = User::find($id);
             if (is_null($user)) {
-                return $this->sendError('User not found.',404);
+                return $this->sendError('User not found.', 404);
             }
 
             return $this->sendResponse($user, 'User retrieved successfully.');
@@ -109,7 +107,7 @@
         {
             $user = User::find($id);
             if (is_null($user)) {
-                return $this->sendError('User not found.',404);
+                return $this->sendError('User not found.', 404);
             }
 
             $user->delete();
diff --git a/Providers/AuthServiceProvider.php b/Providers/AuthServiceProvider.php
index 1a6dd8a..7630bd0 100644
--- a/Providers/AuthServiceProvider.php
+++ b/Providers/AuthServiceProvider.php
@@ -51,7 +51,8 @@ class AuthServiceProvider extends ServiceProvider
             module_path($this->moduleName, 'Config/config.php') => config_path($this->moduleNameLower . '.php'),
         ], 'config');
         $this->mergeConfigFrom(
-            module_path($this->moduleName, 'Config/config.php'), $this->moduleNameLower
+            module_path($this->moduleName, 'Config/config.php'),
+            $this->moduleNameLower
         );
     }
 
diff --git a/Providers/RouteServiceProvider.php b/Providers/RouteServiceProvider.php
index 2efa665..3269b05 100644
--- a/Providers/RouteServiceProvider.php
+++ b/Providers/RouteServiceProvider.php
@@ -14,18 +14,6 @@ class RouteServiceProvider extends ServiceProvider
      */
     protected $moduleNamespace = 'Modules\Auth\Http\Controllers';
 
-    /**
-     * Called before routes are registered.
-     *
-     * Register any model bindings or pattern based filters.
-     *
-     * @return void
-     */
-    public function boot()
-    {
-        parent::boot();
-    }
-
     /**
      * Define the routes for the application.
      *