daengdeni/lpj
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Perbaiki logika validasi jenis legalitas jaminan

Browse Source 
- Tambahkan pengecekan null untuk menghindari error ketika `_jenisJaminan` kosong.
- Perbaiki pengolahan data pada `legalitasJaminan` dan `currentLegalitasJaminan` agar lebih aman.
- Pastikan variabel `legalitas` hanya diisi jika `_jenisJaminan` valid.
This commit is contained in:
Daeng Deni Mardaeni
2024-12-20 11:24:26 +07:00
parent 4bc8346f77
commit f5119e188a
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
app/Http/Controllers/DokumenJaminanController.php
View File

@@ -327,18 +327,21 @@
$jenisLegalitasJaminan = JenisLegalitasJaminan::all(); $jenisLegalitasJaminan = JenisLegalitasJaminan::all();
$_jenisJaminan = JenisJaminan::find($document->jenis_jaminan_id); $_jenisJaminan = JenisJaminan::find($document->jenis_jaminan_id);
$legalitasJaminan = json_decode($_jenisJaminan->jenis_legalitas_jaminan_id, true); $legalitas='';
if($_jenisJaminan) {
$legalitasJaminan = json_decode($_jenisJaminan->jenis_legalitas_jaminan_id, true);
$currentLegalitasJaminan = JenisLegalitasJaminan::whereIn( $currentLegalitasJaminan = JenisLegalitasJaminan::whereIn(
'id', 'id',
$document->detail->pluck('jenis_legalitas_jaminan_id')->toArray(), $document->detail->pluck('jenis_legalitas_jaminan_id')->toArray(),
)->get(); )->get();
// Remove values from $legalitasJaminan that are in $currentLegalitasJaminan // Remove values from $legalitasJaminan that are in $currentLegalitasJaminan
$legalitasJaminan = array_diff($legalitasJaminan, $currentLegalitasJaminan->pluck('code')->toArray()); $legalitasJaminan = array_diff($legalitasJaminan, $currentLegalitasJaminan->pluck('code')->toArray());
$legalitas = JenisLegalitasJaminan::whereIn('code', $legalitasJaminan)->get(); $legalitas = JenisLegalitasJaminan::whereIn('code', $legalitasJaminan)->get();
}
$pemilikJaminan = PemilikJaminan::where('debiture_id', $document->debiture_id)->get(); $pemilikJaminan = PemilikJaminan::where('debiture_id', $document->debiture_id)->get();
$hubunganPemilik = HubunganPemilikJaminan::all(); $hubunganPemilik = HubunganPemilikJaminan::all();