daengdeni/webstatement
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(webstatement): optimize balance assignment in ProcessAccountDataJob

Browse Source 
- Mengubah logika assignment nilai balance untuk memanfaatkan operator null coalescing (??).
- Menghapus pengecekan eksplisit untuk `isset` pada `open_actual_bal` dan `open_cleared_bal`.
- Menambahkan default value `0` jika data balance tidak tersedia.

Signed-off-by: Daeng Deni Mardaeni <ddeni05@gmail.com>
This commit is contained in:
Daeng Deni Mardaeni
2025-05-23 21:42:46 +07:00
parent cb0a248ce5
commit 3414fd9414
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/Jobs/ProcessAccountDataJob.php
View File

@@ -102,13 +102,8 @@
]); ]);
// Set the balances // Set the balances
if (isset($data['open_actual_bal'])) { $accountBalance->actual_balance = $data['open_actual_bal'] ?? 0;
$accountBalance->actual_balance = $data['open_actual_bal']; $accountBalance->cleared_balance = $data['open_cleared_bal'] ?? 0;
}
if (isset($data['open_cleared_bal'])) {
$accountBalance->cleared_balance = $data['open_cleared_bal'];
}
$accountBalance->save(); $accountBalance->save();
Log::info("Saved balance for account {$data['account_number']} for period $period"); Log::info("Saved balance for account {$data['account_number']} for period $period");