daengdeni/webstatement
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(webstatement): remove _parameter folder skipping logic from processing jobs

Browse Source 
- Menghapus logika pengecekan dan pengabaian folder `_parameter` di seluruh job pemrosesan data berikut:
  - `ProcessAccountDataJob`
  - `ProcessAtmTransactionJob`
  - `ProcessBillDetailDataJob`
  - `ProcessCategoryDataJob`
  - `ProcessCompanyDataJob`
  - `ProcessCustomerDataJob`
  - `ProcessDataCaptureDataJob`
  - `ProcessFundsTransferDataJob`
  - `ProcessStmtEntryDataJob`
  - `ProcessTellerDataJob`
- Menghapus konstanta `PARAMETER_FOLDER` yang terkait dengan folder `_parameter` pada beberapa job.
- Membersihkan code redundancy yang tidak relevan untuk meningkatkan keterbacaan dan efisiensi.
- Logika ini dianggap tidak diperlukan lagi dalam proses pemrosesan data.

Signed-off-by: Daeng Deni Mardaeni <ddeni05@gmail.com>
This commit is contained in:
Daeng Deni Mardaeni
2025-05-24 19:43:54 +07:00
parent cd447eb019
commit 38987ce8e3
10 changed files with 0 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/Jobs/ProcessAccountDataJob.php
View File

@@ -44,12 +44,6 @@
return;
}
// Skip the _parameter folder
if ($this->period === '_parameter') {
Log::info("Skipping _parameter folder");
return;
}
// Construct the filename based on the period folder name
$filename = "{$this->period}.ST.ACCOUNT.csv";
$filePath = "{$this->period}/$filename";

8
app/Jobs/ProcessAtmTransactionJob.php
View File

@@ -16,8 +16,6 @@
{
use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
private const PARAMETER_FOLDER = '_parameter';
// Konstanta untuk nilai-nilai statis
private const FILE_EXTENSION = '.ST.ATM.TRANSACTION.csv';
private const CSV_DELIMITER = '~';
@@ -67,12 +65,6 @@
return;
}
// Skip the parameter folder
if ($this->period === self::PARAMETER_FOLDER) {
Log::info("Skipping " . self::PARAMETER_FOLDER . " folder");
return;
}
$stats = $this->processPeriodFile();
Log::info("ProcessAtmTransactionJob completed. Total processed: {$stats['processed']}, Total errors: {$stats['errors']}");

5
app/Jobs/ProcessBillDetailDataJob.php
View File

@@ -42,11 +42,6 @@
return;
}
// Skip the _parameter folder
if ($this->period === '_parameter') {
Log::info("Skipping _parameter folder");
return;
}
// Construct the filename based on the period folder name
$filename = "{$this->period}.ST.AA.BILL.DETAILS.csv";

6
app/Jobs/ProcessCategoryDataJob.php
View File

@@ -43,12 +43,6 @@
return;
}
// Skip the _parameter folder
if ($this->period === '_parameter') {
Log::info("Skipping _parameter folder");
return;
}
// Construct the filename based on the period folder name
$filename = "{$this->period}.ST.CATEGORY.csv";
$filePath = "{$this->period}/$filename";

6
app/Jobs/ProcessCompanyDataJob.php
View File

@@ -45,12 +45,6 @@
return;
}
// Skip the _parameter folder
if ($this->period === '_parameter') {
Log::info("Skipping _parameter folder");
return;
}
// Construct the filepath based on the period folder name
$fileName = "{$this->period}.{$this->filename}";
$filePath = "{$this->period}/$fileName";

6
app/Jobs/ProcessCustomerDataJob.php
View File

@@ -36,12 +36,6 @@
return;
}
// Skip the _parameter folder
if ($this->period === '_parameter') {
Log::info("Skipping _parameter folder");
return;
}
// Construct the filename based on the period folder name
$filename = "{$this->period}.ST.CUSTOMER.csv";
$filePath = "{$this->period}/$filename";

6
app/Jobs/ProcessDataCaptureDataJob.php
View File

@@ -45,12 +45,6 @@
return;
}
// Skip the _parameter folder
if ($this->period === '_parameter') {
Log::info("Skipping _parameter folder");
return;
}
// Construct the filepath based on the period folder name
$fileName = "{$this->period}.{$this->filename}";
$filePath = "{$this->period}/$fileName";

6
app/Jobs/ProcessFundsTransferDataJob.php
View File

@@ -43,12 +43,6 @@
return;
}
// Skip the _parameter folder
if ($this->period === '_parameter') {
Log::info("Skipping _parameter folder");
return;
}
// Construct the filename based on the period folder name
$filename = "{$this->period}.ST.FUNDS.TRANSFER.csv";
$filePath = "{$this->period}/$filename";

6
app/Jobs/ProcessStmtEntryDataJob.php
View File

@@ -43,12 +43,6 @@
return;
}
// Skip the _parameter folder
if ($this->period === '_parameter') {
Log::info("Skipping _parameter folder");
return;
}
// Construct the filename based on the period folder name
$filename = "{$this->period}.ST.STMT.ENTRY.csv";
$filePath = "{$this->period}/$filename";

8
app/Jobs/ProcessTellerDataJob.php
View File

@@ -16,8 +16,6 @@
{
use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
private const PARAMETER_FOLDER = '_parameter';
// Konstanta untuk nilai-nilai statis
private const FILE_EXTENSION = '.ST.TELLER.csv';
private const CSV_DELIMITER = '~';
@@ -153,12 +151,6 @@
return;
}
// Skip the parameter folder
if ($this->period === self::PARAMETER_FOLDER) {
Log::info("Skipping " . self::PARAMETER_FOLDER . " folder");
return;
}
$stats = $this->processPeriodFile();
Log::info("ProcessTellerDataJob completed. Total processed: {$stats['processed']}, Total errors: {$stats['errors']}");