daengdeni/webstatement
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(webstatement): perbaikan pengecekan variabel periode dalam processing data

Browse Source 
Memperbaiki pengecekan variabel `$this->period` dari `empty()` menjadi `=== ''` pada berbagai job dalam modul Webstatement untuk memastikan logika validasi berfungsi dengan baik dan lebih eksplisit.

- Job yang diperbaiki:
  - `ProcessAccountDataJob`
  - `ProcessArrangementDataJob`
  - `ProcessAtmTransactionJob`
  - `ProcessBillDetailDataJob`
  - `ProcessCategoryDataJob`
  - `ProcessCompanyDataJob`
  - `ProcessCustomerDataJob`
  - `ProcessDataCaptureDataJob`
  - `ProcessFundsTransferDataJob`
  - `ProcessStmtEntryDataJob`
  - `ProcessTellerDataJob`

- Memastikan validasi terhadap variabel `$this->period` hanya memfokuskan pada apakah nilainya adalah string kosong (`''`).
- Menambahkan kejelasan pada logging apabila periode tidak tersedia pada setiap job.
- Perubahan ini bertujuan untuk menghindari potensi false negative pada pengecekan kondisi `empty()` yang dapat menyebabkan logika tidak berjalan sebagaimana mestinya.

Signed-off-by: Daeng Deni Mardaeni <ddeni05@gmail.com>
This commit is contained in:
Daeng Deni Mardaeni
2025-05-26 09:05:53 +07:00
parent 23611ef79b
commit 8abb8f6901
11 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Jobs/ProcessAccountDataJob.php
View File

@@ -39,7 +39,7 @@
$processedCount = 0;
$errorCount = 0;
if (empty($this->period)) {
if ($this->period === '') {
Log::warning('No period provided for account data processing');
return;
}

2
app/Jobs/ProcessArrangementDataJob.php
View File

@@ -37,7 +37,7 @@
$processedCount = 0;
$errorCount = 0;
if (empty($this->period)) {
if ($this->period === '') {
Log::warning('No period provided for arrangement data processing');
return;
}

2
app/Jobs/ProcessAtmTransactionJob.php
View File

@@ -60,7 +60,7 @@
try {
set_time_limit(24 * 60 * 60);
if (empty($this->period)) {
if ($this->period === '')) {
Log::warning('No period provided for ATM transaction data processing');
return;
}

2
app/Jobs/ProcessBillDetailDataJob.php
View File

@@ -37,7 +37,7 @@
$processedCount = 0;
$errorCount = 0;
if (empty($this->period)) {
if ($this->period === '')) {
Log::warning('No period provided for bill detail data processing');
return;
}

2
app/Jobs/ProcessCategoryDataJob.php
View File

@@ -38,7 +38,7 @@
$processedCount = 0;
$errorCount = 0;
if (empty($this->period)) {
if ($this->period === '')) {
Log::warning('No period provided for category data processing');
return;
}

2
app/Jobs/ProcessCompanyDataJob.php
View File

@@ -40,7 +40,7 @@
$processedCount = 0;
$errorCount = 0;
if (empty($this->period)) {
if ($this->period === '')) {
Log::warning('No period provided for company data processing');
return;
}

2
app/Jobs/ProcessCustomerDataJob.php
View File

@@ -31,7 +31,7 @@
$processedCount = 0;
$errorCount = 0;
if (empty($this->period)) {
if ($this->period === '')) {
Log::warning('No period provided for customer data processing');
return;
}

2
app/Jobs/ProcessDataCaptureDataJob.php
View File

@@ -40,7 +40,7 @@
$processedCount = 0;
$errorCount = 0;
if (empty($this->period)) {
if ($this->period === '')) {
Log::warning('No period provided for data capture processing');
return;
}

2
app/Jobs/ProcessFundsTransferDataJob.php
View File

@@ -38,7 +38,7 @@
$processedCount = 0;
$errorCount = 0;
if (empty($this->period)) {
if ($this->period === '')) {
Log::warning('No period provided for funds transfer data processing');
return;
}

2
app/Jobs/ProcessStmtEntryDataJob.php
View File

@@ -38,7 +38,7 @@
$processedCount = 0;
$errorCount = 0;
if (empty($this->period)) {
if ($this->period === '')) {
Log::warning('No period provided for statement entry data processing');
return;
}

2
app/Jobs/ProcessTellerDataJob.php
View File

@@ -146,7 +146,7 @@
try {
set_time_limit(24 * 60 * 60);
if (empty($this->period)) {
if ($this->period === '')) {
Log::warning('No period provided for teller data processing');
return;
}