fixing sonarcube

This commit is contained in:
Daeng Deni Mardaeni 2023-06-07 10:26:03 +07:00
parent d09915c09b
commit 44f9593644
5 changed files with 19 additions and 41 deletions

View File

@ -1,26 +1,18 @@
<?php
namespace Modules\Auth\Database\Seeders;
namespace Modules\Auth\Database\Seeders;
use Illuminate\Database\Seeder;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Seeder;
use Illuminate\Database\Eloquent\Model;
class AuthDatabaseSeeder extends Seeder
{
class AuthDatabaseSeeder extends Seeder
{
/**
* Run the database seeds.
*
* @return void
*/
public function run() : void
public function run(): void
{
// \App\Models\User::factory(10)->create();
// \App\Models\User::factory()->create([
// 'name' => 'Test User',
// 'email' => 'test@example.com',
// ]);
// $this->call("OthersTableSeeder");
}
}
}

View File

@ -2,7 +2,6 @@
namespace Modules\Auth\Entities;
// use Illuminate\Contracts\Auth\MustVerifyEmail;
use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Foundation\Auth\User as Authenticatable;
use Illuminate\Notifications\Notifiable;

View File

@ -16,8 +16,7 @@
*
* @return Renderable
*/
public function index()
: JsonResponse
public function index(): JsonResponse
{
$users = User::all();
return $this->sendResponse($users, 'Users retrieved successfully.');
@ -30,8 +29,7 @@
*
* @return Renderable
*/
public function store(Request $request)
: JsonResponse
public function store(Request $request): JsonResponse
{
$validator = Validator::make($request->all(), [
'name' => 'required',
@ -59,11 +57,11 @@
*
* @return Renderable
*/
public function show($id) : JsonResponse
public function show($id): JsonResponse
{
$user = User::find($id);
if (is_null($user)) {
return $this->sendError('User not found.',404);
return $this->sendError('User not found.', 404);
}
return $this->sendResponse($user, 'User retrieved successfully.');
@ -109,7 +107,7 @@
{
$user = User::find($id);
if (is_null($user)) {
return $this->sendError('User not found.',404);
return $this->sendError('User not found.', 404);
}
$user->delete();

View File

@ -51,7 +51,8 @@ class AuthServiceProvider extends ServiceProvider
module_path($this->moduleName, 'Config/config.php') => config_path($this->moduleNameLower . '.php'),
], 'config');
$this->mergeConfigFrom(
module_path($this->moduleName, 'Config/config.php'), $this->moduleNameLower
module_path($this->moduleName, 'Config/config.php'),
$this->moduleNameLower
);
}

View File

@ -14,18 +14,6 @@ class RouteServiceProvider extends ServiceProvider
*/
protected $moduleNamespace = 'Modules\Auth\Http\Controllers';
/**
* Called before routes are registered.
*
* Register any model bindings or pattern based filters.
*
* @return void
*/
public function boot()
{
parent::boot();
}
/**
* Define the routes for the application.
*