daengdeni/webstatement
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(webstatement): perbaiki logika kondisi periode kosong di job processing

Browse Source 
- Memperbaiki kondisi pengecekan `$this->period` yang salah (ekstra tanda kurung) pada beberapa job processing, seperti:
  1. `ProcessAtmTransactionJob`
  2. `ProcessBillDetailDataJob`
  3. `ProcessCategoryDataJob`
  4. `ProcessCompanyDataJob`
  5. `ProcessCustomerDataJob`
  6. `ProcessDataCaptureDataJob`
  7. `ProcessFundsTransferDataJob`
  8. `ProcessStmtEntryDataJob`
  9. `ProcessTellerDataJob`
- Menambahkan kejelasan logging untuk kasus ketika periode tidak disediakan (`period === ''`).
- Menghapus kode komentar tidak terpakai di `ProcessFtTxnTypeConditionJob`.

Perubahan ini memastikan bahwa logika untuk kondisi periode kosong berjalan dengan benar dan menghindari potensi error di runtime.

Signed-off-by: Daeng Deni Mardaeni <ddeni05@gmail.com>
This commit is contained in:
Daeng Deni Mardaeni
2025-05-26 09:12:17 +07:00
parent 8abb8f6901
commit 6a7a3418b7
10 changed files with 9 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Jobs/ProcessAtmTransactionJob.php
View File

@@ -60,7 +60,7 @@
try {
set_time_limit(24 * 60 * 60);
if ($this->period === '')) {
if ($this->period === '') {
Log::warning('No period provided for ATM transaction data processing');
return;
}

2
app/Jobs/ProcessBillDetailDataJob.php
View File

@@ -37,7 +37,7 @@
$processedCount = 0;
$errorCount = 0;
if ($this->period === '')) {
if ($this->period === '') {
Log::warning('No period provided for bill detail data processing');
return;
}

2
app/Jobs/ProcessCategoryDataJob.php
View File

@@ -38,7 +38,7 @@
$processedCount = 0;
$errorCount = 0;
if ($this->period === '')) {
if ($this->period === '') {
Log::warning('No period provided for category data processing');
return;
}

2
app/Jobs/ProcessCompanyDataJob.php
View File

@@ -40,7 +40,7 @@
$processedCount = 0;
$errorCount = 0;
if ($this->period === '')) {
if ($this->period === '') {
Log::warning('No period provided for company data processing');
return;
}

2
app/Jobs/ProcessCustomerDataJob.php
View File

@@ -31,7 +31,7 @@
$processedCount = 0;
$errorCount = 0;
if ($this->period === '')) {
if ($this->period === '') {
Log::warning('No period provided for customer data processing');
return;
}

2
app/Jobs/ProcessDataCaptureDataJob.php
View File

@@ -40,7 +40,7 @@
$processedCount = 0;
$errorCount = 0;
if ($this->period === '')) {
if ($this->period === '') {
Log::warning('No period provided for data capture processing');
return;
}

5
app/Jobs/ProcessFtTxnTypeConditionJob.php
View File

@@ -45,11 +45,6 @@ class ProcessFtTxnTypeConditionJob implements ShouldQueue
}
foreach ($this->periods as $period) {
// Skip the _parameter folder
/*if ($period === '_parameter') {
Log::info("Skipping _parameter folder");
continue;
}*/
// Construct the filepath based on the period folder name
$filePath = "$period/{$this->filename}";

2
app/Jobs/ProcessFundsTransferDataJob.php
View File

@@ -38,7 +38,7 @@
$processedCount = 0;
$errorCount = 0;
if ($this->period === '')) {
if ($this->period === '') {
Log::warning('No period provided for funds transfer data processing');
return;
}

2
app/Jobs/ProcessStmtEntryDataJob.php
View File

@@ -38,7 +38,7 @@
$processedCount = 0;
$errorCount = 0;
if ($this->period === '')) {
if ($this->period === '') {
Log::warning('No period provided for statement entry data processing');
return;
}

2
app/Jobs/ProcessTellerDataJob.php
View File

@@ -146,7 +146,7 @@
try {
set_time_limit(24 * 60 * 60);
if ($this->period === '')) {
if ($this->period === '') {
Log::warning('No period provided for teller data processing');
return;
}